c# - Combine check boxes without using if -


i'm making password generator , have 3 check boxes: lowercase, uppercase, , number. right have if statement says:

    if (check1.checked == true & check2.checked == true & check3.checked == true)        {            length = convert.toint32(lengthtextbox.text);                 string password = "";                 int choice;                 generate gen = new generate();                 (int = 1; <= length; i++)                 {                     choice = rnd.next(1, 4);                     if (choice == 1)                     {                         password = password + gen.lower();                     }                     else if (choice == 2)                     {                         password = password + gen.upper();                     }                     else if (choice == 3)                     {                         password = password + gen.number();                     }                 }                  passwordtextbox.text = password;        }     else if (check1.checked == true & check2.checked == true)     {             length = convert.toint32(lengthtextbox.text);                 string password = "";                 int choice;                 generate gen = new generate();                 (int = 1; <= length; i++)                 {                     choice = rnd.next(1, 3);                     if (choice == 1)                     {                         password = password + gen.lower();                     }                     else if (choice == 2)                     {                         password = password + gen.upper();                     }                 }                  passwordtextbox.text = password;     }

and on. method terribly inefficient. ran problem while making cash register program (10 choices of toppings, check ones want, , program adds prices together. if uncheck topping, price subtracted amount.), gave on it. now, determined find way metaphorically go shopping.

so need here find way of making selection of choice dynamic. 1 way of doing create list of functions in each function capable of generating value. @ start populate list relevant functions based on what's checked, , can have single loop chooses 1 of functions list:

list<func<char>> generators = new list<func<char>>(); if (lowercasecheckbox.checked)     generators.add(() => gen.lowercase());  if (uppercasecheckbox.checked)     generators.add(() => gen.uppercase());  if (numbercheckbox.checked)     generators.add(() => gen.number());  int length = convert.toint32(lengthtextbox.text); stringbuilder password = new stringbuilder(); random random = new random(); (int = 0; < length; i++) {     int choice = random.next(generators.count);     password.append(generators[choice]()); } string result = password.tostring();

note rather appending characters string repeatedly in loop should using stringbuilder avoid constant re-allocation , copying of values.

i suggest using more meaningful names checkbox variables; makes code more readable.


Comments

Post a Comment

Popular posts from this blog

c++ - CryptStringToBinary API behavior -

i seeing strange behavior cryptstringtobinary cryptography api. please see below code (config: x64 debug): #include "stdafx.h" #include <windows.h> #include <strsafe.h> #include <iostream> #include <exception> void main() { dword dwskip; dword dwflags; dword dwdatalen; //lpcwstr pszinput = l"jaaaaaecaaadzgaaakqaagdnnl1l56bwgfjdgr3rpxtqqqn6daw3usv2emkjym4t"; //this works fine lpcwstr pszinput = l"mytest"; //doesnt work, api returns false,error code 0x0000000d // determine size of byte array , allocate memory. if(! cryptstringtobinary( pszinput, _tcslen( pszinput ) + 1, crypt_string_base64, null, &dwdatalen, &dwskip, &dwflags ) ) { dword dw = getlasterror(); //0x0000000d: data invalid throw std::exception( "error computing byte length." ); } byte *pbytebyte = null; try { ...
Read more

java.util.scanner - How to read and add only numbers to array from a text file -

i'm learning java , have question regarding reading file want read numbers file contains strings well. here example of file: 66.56 "3 java 3-43 5-42 2.1 1 and here coding: public class test { public static void main (string [] args){ if (0 < args.length) { file x = new file(args[0]); try{ scanner in = new scanner( new fileinputstream(x)); arraylist<double> test = new arraylist<>(); while(in.hasnext()){ if(in.hasnextdouble()){ double f=in.nextdouble(); test.add(f);} else {in.next();} } catch(ioexception e) { system.err.println("exception during reading: " + e); } } my problem add 66.56,2.1 , 1 doesn't add 3 after "3 or ignores 3-43 , 5-42 can tell me how skip strings , add doubles here? thanks all said 3 ie; "3, 3-43 , 4-42 strings either u read string , split , check number @ " , - or put in space between characters , integers. jvm after compilation tre...
Read more

iphone - Three second countdown in cocos2d -

i trying have 3 second countdown display when level beat in game. did: -(void) gamesegmentbeat { [self pauseschedulerandactions]; // overlay game opaque background ccsprite *opaquebg = [ccsprite spritewithfile:@"background1.png"]; opaquebg.position = screencenter; [self addchild:opaquebg z:10000]; // these 3 labels 3 seconds cclabelttf *three = [cclabelttf labelwithstring:@"3" fontname:@"helvetica" fontsize:100]; three.position = ccp(screencenter.x, screencenter.y); cclabelttf *two = [cclabelttf labelwithstring:@"2" fontname:@"helvetica" fontsize:100]; two.position = ccp(screencenter.x, screencenter.y); cclabelttf *one = [cclabelttf labelwithstring:@"1" fontname:@"helvetica" fontsize:100]; one.position = ccp(screencenter.x, screencenter.y); // secondspast specified in update method secondspast = 0; if (secondspast == 1) { [self addchild:thr...
Read more