C++ possible coin combinations using while loop -


i have challenge in programming class have use void function calculate possible coin combinations given change value 1 99 cents.

so far code looks this:

    #include <iostream>  using namespace std;  void computecoins(int coinvalue, int& num, int& amount_left);  int main() {     //define varibles user input change     int leftover, quarters=0, dimes=0, nickels=0, pennies=0, coins=0, originalamount;         {     cout << "enter change amount: ";     cin >> originalamount;     leftover = originalamount;     } while ((leftover > 99) || (leftover < 1)); //larger 99 or smaller 1? if yes, try again.      //quarters     computecoins(25, coins, leftover);     quarters = coins;      //dimes     computecoins(10, coins, leftover);     dimes = coins;      //nickels     computecoins(5, coins, leftover);     nickels = coins;     pennies = leftover;      cout << originalamount << " cent/s given " << quarters << " quarter/s, " << dimes << " dime/s, " << nickels << " nickel/s, " << " , " << pennies << " pennies.";     cout << endl;     system("pause");     return 0; }  void computecoins(int coinvalue, int& num, int& amount_left) {     //using specified coin value, find how many can go subtract     while (amount_left % coinvalue == 0)     {         // still dividable coin value         num += 1;         amount_left -= coinvalue;     } }

now problem when run program, returns large negative value quarters, dimes, , nickels. i'm positive has how loop conditions set up, have idea why happening?

two issues: 1 undefined coins initial value. 2 amount_left % coinvalue == 0 part - think mean amount_left >= coinvalue

although there no need keep iterating in function

void computecoins(int coinvalue, int& num, int& amount_left) {     // add many coinvalues possible.         num += amount_left / coinvalue;     // modulus must left.     amount_left = amount_left % coinvalue; }

note (among other things), you'd better off using unsigned ints quantities of things.


Comments

Post a Comment

Popular posts from this blog

c++ - CryptStringToBinary API behavior -

i seeing strange behavior cryptstringtobinary cryptography api. please see below code (config: x64 debug): #include "stdafx.h" #include <windows.h> #include <strsafe.h> #include <iostream> #include <exception> void main() { dword dwskip; dword dwflags; dword dwdatalen; //lpcwstr pszinput = l"jaaaaaecaaadzgaaakqaagdnnl1l56bwgfjdgr3rpxtqqqn6daw3usv2emkjym4t"; //this works fine lpcwstr pszinput = l"mytest"; //doesnt work, api returns false,error code 0x0000000d // determine size of byte array , allocate memory. if(! cryptstringtobinary( pszinput, _tcslen( pszinput ) + 1, crypt_string_base64, null, &dwdatalen, &dwskip, &dwflags ) ) { dword dw = getlasterror(); //0x0000000d: data invalid throw std::exception( "error computing byte length." ); } byte *pbytebyte = null; try { ...
Read more

c++ - Correct method for redrawing a layered window -

i have window created ws_ex_layered window style. drawing onto memory bitmap using gdi+, , using updatelayeredwindow update graphical content of layered window. intend use window main window of application, require redraw frequently. seeing layered windows not receive wm_paint windows message [?] , need come appropriate method re-drawing window. optimisation not essential , it's nice have cake , eat too. therefore, in search of "correct" method use. here thoughts far: i guess it's idea render onto off-screen bitmap before bitblt ing or similar. 60 frames rendered per second should (more than?) enough (but how compare other applications' frame rates?). possible solutions: use settimer send wm_timer message on regular basis. useful because through specifying time-out value, can achieve desired frames per second, without requirement measure duration "frame" takes rendered. would cause input or other lags due frequency , speed of m...
Read more

java.util.scanner - How to read and add only numbers to array from a text file -

i'm learning java , have question regarding reading file want read numbers file contains strings well. here example of file: 66.56 "3 java 3-43 5-42 2.1 1 and here coding: public class test { public static void main (string [] args){ if (0 < args.length) { file x = new file(args[0]); try{ scanner in = new scanner( new fileinputstream(x)); arraylist<double> test = new arraylist<>(); while(in.hasnext()){ if(in.hasnextdouble()){ double f=in.nextdouble(); test.add(f);} else {in.next();} } catch(ioexception e) { system.err.println("exception during reading: " + e); } } my problem add 66.56,2.1 , 1 doesn't add 3 after "3 or ignores 3-43 , 5-42 can tell me how skip strings , add doubles here? thanks all said 3 ie; "3, 3-43 , 4-42 strings either u read string , split , check number @ " , - or put in space between characters , integers. jvm after compilation tre...
Read more