Getting incorrect ouput when passing a string variable, defined by user input, to a setter method in Java -


this question has answer here:

new java. understand strings immutable, don't understand why output here way is.

the goal: i'm trying ask user question "what class want be?", user answers. answer stored in string variable (classentered), , passed setclass method returns starting hp , starting gold based on input classentered.

the problem: when user enters kind of character want (i.e. warlock or warrior), playerclass gets updated properly. output (startinghp / startinggold) not respond correctly.

here code:

    class player {          string playername;         string playerclass;         int startinggold;         int startinghp;          public void setname(string playername){             this.playername = playername;         }          public void setclass(string newclass){             playerclass = newclass;             if(playerclass == "warlock"){                 startinghp = 100;                 startinggold = 25;             }else if (playerclass == "warrior"){                 startinghp = 150;                 startinggold = 30;              }         }     }      public class app {          public static void main(string[] args) {              // practice code: if playerclass defined way output correct             player player1 = new player();             player1.setname("jordan");             player1.setclass("warlock");              system.out.println("your name is: " + player1.playername);             system.out.println("you're " + player1.playerclass);             system.out.println("your starting hp " + player1.startinghp + " starting gold " + player1.startinggold);              player player2 = new player();             player2.setname("jorel");             scanner sc = new scanner(system.in);                     system.out.println("what class choose? ");             string classentered = sc.nextline();             player2.setclass(classentered);             system.out.println("testing " + player2.playerclass);             //output incorrect when playerclass defined via scanner             system.out.println("your name is: " + player2.playername);             system.out.println("you're " + player2.playerclass);             system.out.println("your starting hp " + player2.startinghp + " starting gold " + player2.startinggold);         }      }

strings in java case-sensitive. when player inputs class, must write exactly you're comparing in setclass api.

secondly, must use equals method comparing string contents.

if(playerclass.equals("warlock")) {     startinghp = 100;     startinggold = 25; } else if (playerclass.equals("warrior")) {     startinghp = 150;     startinggold = 30;  }

in code, code wasn't entering neither branch of if statement.

more:

  • use constants classes, or separate classes/enums.
  • make setters , getters hp , gold. respect encapsulation.
  • make sure tell use class doesn't exist, if enters "elf", example.
  • to make classes case-insensitive, use equalsignorecase compare strings, instead of equals

Comments

Post a Comment

Popular posts from this blog

c++ - CryptStringToBinary API behavior -

i seeing strange behavior cryptstringtobinary cryptography api. please see below code (config: x64 debug): #include "stdafx.h" #include <windows.h> #include <strsafe.h> #include <iostream> #include <exception> void main() { dword dwskip; dword dwflags; dword dwdatalen; //lpcwstr pszinput = l"jaaaaaecaaadzgaaakqaagdnnl1l56bwgfjdgr3rpxtqqqn6daw3usv2emkjym4t"; //this works fine lpcwstr pszinput = l"mytest"; //doesnt work, api returns false,error code 0x0000000d // determine size of byte array , allocate memory. if(! cryptstringtobinary( pszinput, _tcslen( pszinput ) + 1, crypt_string_base64, null, &dwdatalen, &dwskip, &dwflags ) ) { dword dw = getlasterror(); //0x0000000d: data invalid throw std::exception( "error computing byte length." ); } byte *pbytebyte = null; try { ...
Read more

java.util.scanner - How to read and add only numbers to array from a text file -

i'm learning java , have question regarding reading file want read numbers file contains strings well. here example of file: 66.56 "3 java 3-43 5-42 2.1 1 and here coding: public class test { public static void main (string [] args){ if (0 < args.length) { file x = new file(args[0]); try{ scanner in = new scanner( new fileinputstream(x)); arraylist<double> test = new arraylist<>(); while(in.hasnext()){ if(in.hasnextdouble()){ double f=in.nextdouble(); test.add(f);} else {in.next();} } catch(ioexception e) { system.err.println("exception during reading: " + e); } } my problem add 66.56,2.1 , 1 doesn't add 3 after "3 or ignores 3-43 , 5-42 can tell me how skip strings , add doubles here? thanks all said 3 ie; "3, 3-43 , 4-42 strings either u read string , split , check number @ " , - or put in space between characters , integers. jvm after compilation tre...
Read more

iphone - Three second countdown in cocos2d -

i trying have 3 second countdown display when level beat in game. did: -(void) gamesegmentbeat { [self pauseschedulerandactions]; // overlay game opaque background ccsprite *opaquebg = [ccsprite spritewithfile:@"background1.png"]; opaquebg.position = screencenter; [self addchild:opaquebg z:10000]; // these 3 labels 3 seconds cclabelttf *three = [cclabelttf labelwithstring:@"3" fontname:@"helvetica" fontsize:100]; three.position = ccp(screencenter.x, screencenter.y); cclabelttf *two = [cclabelttf labelwithstring:@"2" fontname:@"helvetica" fontsize:100]; two.position = ccp(screencenter.x, screencenter.y); cclabelttf *one = [cclabelttf labelwithstring:@"1" fontname:@"helvetica" fontsize:100]; one.position = ccp(screencenter.x, screencenter.y); // secondspast specified in update method secondspast = 0; if (secondspast == 1) { [self addchild:thr...
Read more