php - method can return an error or an array - bad implementation? -


i'm reading code complete , there statement in warns against using variable double purpose, example:

1) if variable number, contains error code. 2) if varibale array, contains data.

and that's i'm doing in program variable $text in code snippet below:

$text = $editor->gettextforlinking($data_array['idtext']); if (arr::is_array($text)) {     ... } else {     log::instance()->add(log::error, $text);     $this->response->body("text can't retrieved"); }

i have access method gettextforlinking() can changed. how can changed exclude undesirable situation double purpose?

i don't want use exceptions this:

$text = array(); try {     $text = $editor->gettextforlinking($data_array['idtext']); } catch(someexception $e) {     log::instance()->add(log::error, $text);     $this->response->body("text can't retrieved"); }

i think clear if returned gettextforlinking(), not array, should considered error (logged) - i'm not entirely convinced example warrants such change.

with said might improvement keep return signature of function same data type (array) regardless of data send it. way consistent (you loose need $text = array();) , wont have make special cases depending on if error or not.

$results = $editor->gettextforlinking($data_array['idtext']); if (empty($results)) {    log::instance()->add(log::error, $data_array['idtext']); } else {   // handle results array  }

update

if setting error message within function, violates single responsibility principle - function/method should have 1 job. far $editor->gettextforlinking() concerned return array of text, not deal return of error.

the error message should depend on context (where method used). if @ point empty array invalid handle/set error (message) outside of function have shown above.

doing way allows $editor oblivious of validity of returned result , allow reuse function elsewhere empty array not considered error.


Comments

Post a Comment

Popular posts from this blog

java.util.scanner - How to read and add only numbers to array from a text file -

i'm learning java , have question regarding reading file want read numbers file contains strings well. here example of file: 66.56 "3 java 3-43 5-42 2.1 1 and here coding: public class test { public static void main (string [] args){ if (0 < args.length) { file x = new file(args[0]); try{ scanner in = new scanner( new fileinputstream(x)); arraylist<double> test = new arraylist<>(); while(in.hasnext()){ if(in.hasnextdouble()){ double f=in.nextdouble(); test.add(f);} else {in.next();} } catch(ioexception e) { system.err.println("exception during reading: " + e); } } my problem add 66.56,2.1 , 1 doesn't add 3 after "3 or ignores 3-43 , 5-42 can tell me how skip strings , add doubles here? thanks all said 3 ie; "3, 3-43 , 4-42 strings either u read string , split , check number @ " , - or put in space between characters , integers. jvm after compilation tre...
Read more

rewrite - Trouble with Wordpress multiple custom querystrings -

i'm working on adding multiple querystring , doesn't seem work. i've found codes seems work others might i'm missing something. i want like: http://mydomain.com/board/?getyear=2013&getsometext2=sometext to http://mydomain.com/board/2013/sometext/ i added code below functions.php file. doesn't seem work should though. this works. echoing querystring gets both variable without problem. http://mydomain.com/board/2013/sometext/ but doesn't. tested querystring vis isset() seems nothing being set/get http://mydomain.com/board/2013/ function add_query_vars($vars) { $vars[] = "getyear"; $vars[] = "getsometext2"; return $vars; } add_filter('query_vars', 'add_query_vars'); function add_rewrite_rules($arules) { $anewrules = array('board/([^/]+)/([^/]+)/?$' => 'index.php?pagename=board&getyear=$matches[1]&getsometext2=$matches[2]'); $arules = $a...
Read more